Fix race condition in gltf-model when changing src while loading#5739
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jun 30, 2025
Merged
Fix race condition in gltf-model when changing src while loading#5739dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
vincentfretin
approved these changes
Jun 20, 2025
Contributor
vincentfretin
left a comment
There was a problem hiding this comment.
This looks great! And the added tests are testing indeed those cases.
@kfarr I think I remember seeing that race condition happening on 3dstreet with the model preview on hover when switching fast enough between cards when we used the same entity, and we currently remove and create a new entity because of that. That was one of the reason anyway.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
gltf-modelcomponent would unconditionally change the model in thegltfLoadcallback. However, it's possible for thesrcvalue to have changed in the meantime. In case the second model finishes loading before the first one, the component would incorrectly end up showing the first model (once it finishes loading as well).This PR adds a check to ensure that the
srchasn't changed (similar to what is done for textures).Changes proposed:
srcchanged while loading model to avoid showing the wrong modelsrcchange and removal logic.