Add a tap listener to the view #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New `TapListener` functional interface in `PdfRendererView` * New `setOnTapListener` method in `PinchZoomRecyclerView` * New `tapListener` field in `PinchZoomRecyclerView` * Listen for single tap events in `PinchZoomRecyclerView.GestureListener` * New `tapListener` field in `PdfRendererView` * Set tap listener in `PdfRendererView::initializeRenderer` * New `tapListener` parameter in `PdfRendererViewCompose` * Set tap listener alongside the status and zoom listeners in `PdfRendererViewCompose`
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for contributing to this project. This is your first pull request and we are so glad to have you onboard. We will review the request and get back to you soon. We love your contributions! Join our Discord community here to discuss this PR or ask questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small feature that would really help me (and a lot of people I guess). It's very difficult to pass events between Android
Views and composables. This would allow anyone to listen for single taps. For example, I want to use this to toggle the app bar visibility in my application.TapListenerfunctional interface inPdfRendererViewsetOnTapListenermethod inPinchZoomRecyclerViewtapListenerfield inPinchZoomRecyclerViewPinchZoomRecyclerView.GestureListenertapListenerfield inPdfRendererViewPdfRendererView::initializeRenderertapListenerparameter inPdfRendererViewComposePdfRendererViewCompose