Skip to content

FinWire Parsing Fixes#1

Open
justinkolpak-databricks wants to merge 6 commits intomainfrom
dev_kolpak
Open

FinWire Parsing Fixes#1
justinkolpak-databricks wants to merge 6 commits intomainfrom
dev_kolpak

Conversation

@justinkolpak-databricks
Copy link
Collaborator

@justinkolpak-databricks justinkolpak-databricks commented Sep 23, 2024

Brief summary of the change made

Fixes to parsing on FinWire. Confirm it works with dbt run and sqlmesh plan

Are there any other side effects of this change that we should be aware of?

Pull Request checklist

  • Verified that these changes work locally
  • Updated the README.md and Documentation (if applicable)
  • Verified that existing unit tests pass (may need to run dbt seed first)
  • [] Added a unit test for each new macro I created and I have verified that these new unit tests pass.
  • [] Created GitHub issues for any relevant follow-up/future enhancements if appropriate.

@justinkolpak-databricks justinkolpak-databricks changed the title Dev kolpak FinWire Parsing Fixes Sep 23, 2024
@justinkolpak-databricks
Copy link
Collaborator Author

justinkolpak-databricks commented Sep 23, 2024

@afzaljasani can you review when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justinkolpak-databricks @afzaljasani