Skip to content

Fix step verification bug: use stepName instead of name #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Fix step verification bug: use stepName instead of name #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions typescript-sdk/packages/client/src/verify/__tests__/verify.steps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe("verifyEvents steps", () => {
await new Promise((resolve) => setTimeout(resolve, 100));

// Verify only events before the error were processed
expect(events.length).toBe(3);
expect(events.length).toBe(2);
expect(events[1].type).toBe(EventType.STEP_STARTED);
});

Expand All @@ -68,7 +68,7 @@ describe("verifyEvents steps", () => {
error: (err) => {
expect(err).toBeInstanceOf(AGUIError);
expect(err.message).toContain(
`Cannot send 'STEP_FINISHED' for step "undefined" that was not started`,
`Cannot send 'STEP_FINISHED' for step "test-step" that was not started`,
);
subscription.unsubscribe();
},
Expand Down Expand Up @@ -106,7 +106,7 @@ describe("verifyEvents steps", () => {
next: (event) => events.push(event),
error: (err) => {
expect(err).toBeInstanceOf(AGUIError);
expect(err.message).toContain(`Step "undefined" is already active for 'STEP_STARTED'`);
expect(err.message).toContain(`Step "test-step" is already active for 'STEP_STARTED'`);
subscription.unsubscribe();
},
});
Expand Down
8 changes: 4 additions & 4 deletions typescript-sdk/packages/client/src/verify/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ export const verifyEvents =
let firstEventReceived = false;
// Track active steps
let activeSteps = new Map<string, boolean>(); // Map of step name -> active status
let activeThinkingStep = false
let activeThinkingStepMessage = false
let activeThinkingStep = false;
let activeThinkingStepMessage = false;

return source$.pipe(
// Process each event through our state machine
Expand Down Expand Up @@ -244,7 +244,7 @@ export const verifyEvents =

// Step flow
case EventType.STEP_STARTED: {
const stepName = (event as any).name;
const stepName = (event as any).stepName;
if (activeSteps.has(stepName)) {
return throwError(
() => new AGUIError(`Step "${stepName}" is already active for 'STEP_STARTED'`),
Expand All @@ -255,7 +255,7 @@ export const verifyEvents =
}

case EventType.STEP_FINISHED: {
const stepName = (event as any).name;
const stepName = (event as any).stepName;
if (!activeSteps.has(stepName)) {
return throwError(
() =>
Expand Down