Skip to content

fix: expose run error in legacy runtime events #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2025
Merged

fix: expose run error in legacy runtime events #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d1fcca
fix: expose run error in legacy runtime events
ranst91 Aug 12, 2025
94c6a64
0.0.36-alpha.2
mme Aug 12, 2025
e4c37c4
fix
ranst91 Aug 12, 2025
82d16a0
0.0.38-alpha.3
mme Aug 13, 2025
46b6444
Merge branch 'main' into fix/legacy-error-message-forwarding
ranst91 Aug 13, 2025
3ea6ae3
chore: remove alpha versions from different packages
ranst91 Aug 13, 2025
ec6af67
Merge branch 'main' into fix/legacy-error-message-forwarding
ranst91 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion typescript-sdk/packages/client/src/legacy/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
StateDeltaEvent,
MessagesSnapshotEvent,
ToolCall,
RunErrorEvent,
} from "@ag-ui/core";
import { Observable } from "rxjs";
import {
Expand All @@ -36,6 +37,7 @@ import {
LegacyActionExecutionMessage,
LegacyResultMessage,
LegacyActionExecutionResult,
LegacyRunError
} from "./types";
import untruncateJson from "untruncate-json";

Expand Down Expand Up @@ -319,7 +321,14 @@ export const convertToLegacyEvents =
case EventType.RUN_ERROR: {
// legacy protocol does not have an event for errors
console.error("Run error", event);
return [];
const errorEvent = event as RunErrorEvent;
return [
{
type: LegacyRuntimeEventTypes.enum.RunError,
message: errorEvent.message,
code: errorEvent.code,
} as LegacyRunError,
];
}
case EventType.STEP_STARTED: {
const stepStarted = event as StepStartedEvent;
Expand Down
9 changes: 9 additions & 0 deletions typescript-sdk/packages/client/src/legacy/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ export const LegacyMetaEvent = z.object({
value: z.any(),
});


export const LegacyRunError = z.object({
type: z.literal(LegacyRuntimeEventTypes.enum.RunError),
message: z.string(),
code: z.string().optional(),
});

export const LegacyRuntimeProtocolEvent = z.discriminatedUnion("type", [
LegacyTextMessageStart,
LegacyTextMessageContent,
Expand All @@ -94,6 +101,7 @@ export const LegacyRuntimeProtocolEvent = z.discriminatedUnion("type", [
LegacyActionExecutionResult,
LegacyAgentStateMessage,
LegacyMetaEvent,
LegacyRunError,
]);

// Protocol Event type exports
Expand All @@ -109,6 +117,7 @@ export type LegacyActionExecutionResult = z.infer<typeof LegacyActionExecutionRe
export type LegacyAgentStateMessage = z.infer<typeof LegacyAgentStateMessage>;
export type LegacyMetaEvent = z.infer<typeof LegacyMetaEvent>;
export type LegacyRuntimeProtocolEvent = z.infer<typeof LegacyRuntimeProtocolEvent>;
export type LegacyRunError = z.infer<typeof LegacyRunError>;

// Message schemas (with kind discriminator)
export const LegacyTextMessageSchema = z.object({
Expand Down