Skip to content

Remove unneeded .fixme and fix more tests #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 28, 2025
Merged

Remove unneeded .fixme and fix more tests #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5e23c6f
Chore: remove e2e2 package
maxkorp Aug 27, 2025
07e891c
add report command
maxkorp Aug 27, 2025
19737af
re-enable all tests
maxkorp Aug 27, 2025
1dc63bf
Fix bug with haiku render order in tool based gen ui
maxkorp Aug 27, 2025
e5b7e6a
fix checkpointer missing in fastapi langgraph toolbasedgenui
maxkorp Aug 27, 2025
e3278c2
rename misspelled files
maxkorp Aug 27, 2025
bd323a9
Make menu bar sorted for easier viewability
maxkorp Aug 27, 2025
3a0d5b3
omit mastra tool based gen
maxkorp Aug 27, 2025
5f7120a
more fixme
maxkorp Aug 27, 2025
aee8a07
fix some strict mode errors
maxkorp Aug 27, 2025
638ee26
Last remaining fixme
maxkorp Aug 27, 2025
6793dd8
mark 2 more flaky tests
maxkorp Aug 27, 2025
70b838c
Add comments on fixmes
maxkorp Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion typescript-sdk/apps/dojo/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"scripts": {
"postinstall": "playwright install --with-deps",
"test": "playwright test",
"test:ui": "playwright test --ui"
"test:ui": "playwright test --ui",
"report": "playwright show-report"
},
"devDependencies": {
"@playwright/test": "^1.43.1",
Expand Down
12 changes: 6 additions & 6 deletions typescript-sdk/apps/dojo/e2e/pages/crewAIPages/PredictiveStateUpdatesPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class PredictiveStateUpdatesPage {
this.userMessage = page.locator('.copilotKitUserMessage');
}

async openChat() {
async openChat() {
await this.agentGreeting.isVisible();
}

Expand All @@ -54,13 +54,13 @@ export class PredictiveStateUpdatesPage {
}

async getUserApproval() {
await this.userApprovalModal.isVisible();
await this.userApprovalModal.last().isVisible();
await this.getButton(this.page, "Confirm");
const acceptedLabel = this.userApprovalModal.locator('text=✓ Accepted');
const acceptedLabel = this.userApprovalModal.last().locator('text=✓ Accepted');
}

async getUserRejection() {
await this.userApprovalModal.isVisible();
await this.userApprovalModal.last().isVisible();
await this.getButton(this.page, "Reject");
const rejectedLabel = await this.getStatusLabelOfButton(this.page, "✕ Rejected");
await rejectedLabel.isVisible();
Expand All @@ -85,15 +85,15 @@ export class PredictiveStateUpdatesPage {
'div.tiptap em',
'div.tiptap s'
];

let count = 0;
for (const selector of highlightSelectors) {
count = await this.page.locator(selector).count();
if (count > 0) {
break;
}
}

if (count > 0) {
expect(count).toBeGreaterThan(0);
} else {
Expand Down
12 changes: 6 additions & 6 deletions typescript-sdk/apps/dojo/e2e/pages/pydanticAIPages/PredictiveStateUpdatesPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class PredictiveStateUpdatesPage {
this.userMessage = page.locator('.copilotKitUserMessage');
}

async openChat() {
async openChat() {
await this.agentGreeting.isVisible();
}

Expand All @@ -54,13 +54,13 @@ export class PredictiveStateUpdatesPage {
}

async getUserApproval() {
await this.userApprovalModal.isVisible();
await this.userApprovalModal.last().isVisible();
await this.getButton(this.page, "Confirm");
const acceptedLabel = this.userApprovalModal.locator('text=✓ Accepted');
const acceptedLabel = this.userApprovalModal.last().locator('text=✓ Accepted');
}

async getUserRejection() {
await this.userApprovalModal.isVisible();
await this.userApprovalModal.last().isVisible();
await this.getButton(this.page, "Reject");
const rejectedLabel = await this.getStatusLabelOfButton(this.page, "✕ Rejected");
await rejectedLabel.isVisible();
Expand All @@ -85,15 +85,15 @@ export class PredictiveStateUpdatesPage {
'div.tiptap em',
'div.tiptap s'
];

let count = 0;
for (const selector of highlightSelectors) {
count = await this.page.locator(selector).count();
if (count > 0) {
break;
}
}

if (count > 0) {
expect(count).toBeGreaterThan(0);
} else {
Expand Down
4 changes: 2 additions & 2 deletions typescript-sdk/apps/dojo/e2e/tests/agnoTests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/agnoPages/ToolBaseGenUIPage";
const pageURL =
"/agno/feature/tool_based_generative_ui";

test.fixme('[Agno] Haiku generation and display verification', async ({
test('[Agno] Haiku generation and display verification', async ({
page,
}) => {
await page.goto(pageURL);
Expand All @@ -17,7 +17,7 @@ test.fixme('[Agno] Haiku generation and display verification', async ({
await genAIAgent.checkHaikuDisplay(page);
});

test.fixme('[Agno] Haiku generation and UI consistency for two different prompts', async ({
test('[Agno] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
await page.goto(pageURL);
Expand Down
2 changes: 1 addition & 1 deletion typescript-sdk/apps/dojo/e2e/tests/crewAITests/agenticChatPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test("[CrewAI] Agentic Chat sends and receives a message", async ({
});
});

test.fixme("[CrewAI] Agentic Chat changes background on message and reset", async ({
test("[CrewAI] Agentic Chat changes background on message and reset", async ({
page,
}) => {
await retryOnAIFailure(async () => {
Expand Down
2 changes: 2 additions & 0 deletions typescript-sdk/apps/dojo/e2e/tests/crewAITests/agenticGenUI.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { test, expect } from "@playwright/test";
import { AgenticGenUIPage } from "../../pages/crewAIPages/AgenticUIGenPage";

test.describe("Agent Generative UI Feature", () => {
// Flaky
test.fixme("[CrewAI] should interact with the chat to get a planner on prompt", async ({
page,
}) => {
Expand Down Expand Up @@ -33,6 +34,7 @@ test.describe("Agent Generative UI Feature", () => {
);
});

// Flaky
test.fixme("[CrewAI] should interact with the chat using predefined prompts and perform steps", async ({
page,
}) => {
Expand Down
0 ...AITests/predictvieStateUpdatePage.spec.ts → ...AITests/predictiveStateUpdatePage.spec.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/agenticGenUI.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test.describe("Agent Generative UI Feature", () => {
);
});

test.fixme("[LangGraph FastAPI] should interact with the chat using predefined prompts and perform steps", async ({
test("[LangGraph FastAPI] should interact with the chat using predefined prompts and perform steps", async ({
page,
}) => {
const genUIAgent = new AgenticGenUIPage(page);
Expand Down
0 ...PITests/predictvieStateUpdatePage.spec.ts → ...PITests/predictiveStateUpdatePage.spec.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/sharedStatePage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test.describe("Shared State Feature", () => {
);
});

test.fixme("[LangGraph FastAPI] should share state between UI and chat", async ({
test("[LangGraph FastAPI] should share state between UI and chat", async ({
page,
}) => {
const sharedStateAgent = new SharedStatePage(page);
Expand Down
4 changes: 2 additions & 2 deletions typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/langGraphFastAPIPages/ToolBaseGen
const pageURL =
"/langgraph-fastapi/feature/tool_based_generative_ui";

test.fixme('[LangGraph FastAPI] Haiku generation and display verification', async ({
test('[LangGraph FastAPI] Haiku generation and display verification', async ({
page,
}) => {
await page.goto(pageURL);
Expand All @@ -17,7 +17,7 @@ test.fixme('[LangGraph FastAPI] Haiku generation and display verification', asyn
await genAIAgent.checkHaikuDisplay(page);
});

test.fixme('[LangGraph FastAPI] Haiku generation and UI consistency for two different prompts', async ({
test('[LangGraph FastAPI] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
await page.goto(pageURL);
Expand Down
0 ...phTests/predictvieStateUpdatePage.spec.ts → ...phTests/predictiveStateUpdatePage.spec.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions typescript-sdk/apps/dojo/e2e/tests/langgraphTests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/langGraphPages/ToolBaseGenUIPage"
const pageURL =
"/langgraph/feature/tool_based_generative_ui";

test.fixme('[LangGraph] Haiku generation and display verification', async ({
test('[LangGraph] Haiku generation and display verification', async ({
page,
}) => {
await page.goto(pageURL);
Expand All @@ -17,7 +17,7 @@ test.fixme('[LangGraph] Haiku generation and display verification', async ({
await genAIAgent.checkHaikuDisplay(page);
});

test.fixme('[LangGraph] Haiku generation and UI consistency for two different prompts', async ({
test('[LangGraph] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
await page.goto(pageURL);
Expand Down
2 changes: 2 additions & 0 deletions typescript-sdk/apps/dojo/e2e/tests/llamaIndexTests/agenticGenUI.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { test, expect } from "@playwright/test";
import { AgenticGenUIPage } from "../../pages/llamaIndexPages/AgenticUIGenPage";

test.describe("Agent Generative UI Feature", () => {
// Fails. Issue with integration or something.
test.fixme("[LlamaIndex] should interact with the chat to get a planner on prompt", async ({
page,
}) => {
Expand Down Expand Up @@ -35,6 +36,7 @@ test.describe("Agent Generative UI Feature", () => {
);
});

// Fails. Issue with integration or something.
test.fixme("[LlamaIndex] should interact with the chat using predefined prompts and perform steps", async ({
page,
}) => {
Expand Down
4 changes: 2 additions & 2 deletions typescript-sdk/apps/dojo/e2e/tests/mastraAgentLocalTests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/mastraAgentLocalPages/ToolBaseGen
const pageURL =
"/mastra-agent-local/feature/tool_based_generative_ui";

test.fixme('[Mastra Agent Local] Haiku generation and display verification', async ({
test('[Mastra Agent Local] Haiku generation and display verification', async ({
page,
}) => {
await page.goto(pageURL);
Expand All @@ -17,7 +17,7 @@ test.fixme('[Mastra Agent Local] Haiku generation and display verification', asy
await genAIAgent.checkHaikuDisplay(page);
});

test.fixme('[Mastra Agent Local] Haiku generation and UI consistency for two different prompts', async ({
test('[Mastra Agent Local] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
await page.goto(pageURL);
Expand Down
2 changes: 2 additions & 0 deletions typescript-sdk/apps/dojo/e2e/tests/mastraTests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/mastraPages/ToolBaseGenUIPage";
const pageURL =
"/mastra/feature/tool_based_generative_ui";

// Fails. Not a test issue, issue with the integration or cpk.
test.fixme('[Mastra] Haiku generation and display verification', async ({
page,
}) => {
Expand All @@ -17,6 +18,7 @@ test.fixme('[Mastra] Haiku generation and display verification', async ({
await genAIAgent.checkHaikuDisplay(page);
});

// Fails. Not a test issue, issue with the integration or cpk.
test.fixme('[Mastra] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
Expand Down
3 changes: 2 additions & 1 deletion ...AITests/predictvieStateUpdatePage.spec.ts → ...AITests/predictiveStateUpdatePage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
import { PredictiveStateUpdatesPage } from "../../pages/pydanticAIPages/PredictiveStateUpdatesPage";

test.describe("Predictive Status Updates Feature", () => {
// Fails. Issue with integration or something.
test.fixme("[PydanticAI] should interact with agent and approve asked changes", async ({
page,
}) => {
Expand Down Expand Up @@ -43,7 +44,7 @@ test.describe("Predictive Status Updates Feature", () => {
});
});

test.fixme("[PydanticAI] should interact with agent and reject asked changes", async ({
test("[PydanticAI] should interact with agent and reject asked changes", async ({
page,
}) => {
await retryOnAIFailure(async () => {
Expand Down
4 changes: 2 additions & 2 deletions typescript-sdk/apps/dojo/e2e/tests/pydanticAITests/toolBasedGenUIPage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/pydanticAIPages/ToolBaseGenUIPage
const pageURL =
"/pydantic-ai/feature/tool_based_generative_ui";

test.fixme('[PydanticAI] Haiku generation and display verification', async ({
test('[PydanticAI] Haiku generation and display verification', async ({
page,
}) => {
await page.goto(pageURL);
Expand All @@ -17,7 +17,7 @@ test.fixme('[PydanticAI] Haiku generation and display verification', async ({
await genAIAgent.checkHaikuDisplay(page);
});

test.fixme('[PydanticAI] Haiku generation and UI consistency for two different prompts', async ({
test('[PydanticAI] Haiku generation and UI consistency for two different prompts', async ({
page,
}) => {
await page.goto(pageURL);
Expand Down
0 ...esTests/predictvieStateUpdatePage.spec.ts → ...esTests/predictiveStateUpdatePage.spec.ts
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions typescript-sdk/apps/dojo/e2e/tests/serverStarterAllFeaturesTests/sharedStatePage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ test.describe("Shared State Feature", () => {
);
});

// Fails. Issue with the test, most likely
test.fixme("[Server Starter all features] should share state between UI and chat", async ({
page,
}) => {
Expand Down
7 changes: 0 additions & 7 deletions typescript-sdk/apps/dojo/e2e2/.gitignore
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions typescript-sdk/apps/dojo/e2e2/package.json
View file
Open in desktop

This file was deleted.

79 changes: 0 additions & 79 deletions typescript-sdk/apps/dojo/e2e2/playwright.config.ts
View file
Open in desktop

This file was deleted.

Loading
Loading