Fix sharedState tests and refactor out some shared pages #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkorp
requested review from
NathanTarbert,
ataibarkai,
mme,
ranst91 and
tylerslaton
as code owners
mattsp1290
pushed a commit
to birbparty/ag-ui
that referenced
this pull request
Sep 8, 2025
…col#335) * Move sharedState and toolbasegenui tests to use shared page file * factor out agenticChatPage * actually await things now * Fix shared state server test * Use better prompt * Fix mastra shared memory breaking when using libsql backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For several features, the "Page" utility files in the tests were identical, or close enough to be combined. Rather than 7 identical files, we can just share one file.
The shared state tests for the ServerStarterAllFeatures agent were incorrect. That example is hardcoded, so tests have been modified to fix that.
The mastra local agent had an invalid config that was causing shared memory backends across agents. Turns out this is fine using the dynamoDB backend, but not when using the libsql backend. Fixed that as well.