fix(dojo): re-enable agentic generative UI test for pydantic ai #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
NathanTarbert,
ataibarkai,
maxkorp,
mme and
ranst91
as code owners
Signed-off-by: Tyler Slaton <[email protected]>
tylerslaton
force-pushed
the
tyler/fix-4418
branch
from
2d1574c to
0073957
Compare
tylerslaton
changed the title
tylerslaton
force-pushed
the
tyler/fix-4418
branch
2 times, most recently
from
6c0db0a to
536372e
Compare
Signed-off-by: Tyler Slaton <[email protected]>
tylerslaton
force-pushed
the
tyler/fix-4418
branch
from
deb8b5d to
e6a5b0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does quite a few things to our E2E CI.
1. Only run the tests that are relevant.
For example, if you make changes in the Pydantic AI integration we will now only run the e2e for that. However, if you edit a core SDK package (like the typescript packages) then it will run everything.
This is mainly to save on CI time for costs.
2. Increases the retries by 1 and wait time by 2 minutes, generally to account for flakey tests.
We had quite a few flakey tests and, since we were previously running them synchronously in order, they would cause our E2E suite to run for quite a long time. Most of these tests can be attributed to latency issues.
3. Breaks out the tests into multiple parallel actions
Reduces run time by 15 minutes (down from 25 minutes)