Testing Fix/issue 400 clean #474
Open
+229
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace fragile usage_metadata-based logic with robust streaming detection that checks multiple explicit streaming indicators. **Problem:** The original logic relied on `not adk_event.usage_metadata` to determine if an event should be processed as streaming. This was fragile because Claude models can include usage_metadata even in streaming chunks, causing responses to disappear. **Solution:** Implement comprehensive streaming detection that checks: - `partial` attribute (explicitly marked as partial) - `turn_complete` attribute (live streaming completion status) - `is_final_response()` method (final response indicator) - `finish_reason` attribute (fallback for content without finish reason) This ensures all streaming content is captured regardless of usage_metadata presence, fixing compatibility with Claude Sonnet 4 and other models. **Testing:** ✅ All 277 tests pass ✅ Streaming detection works across different model providers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…k-agent Add regression test for partial final ADK chunks
Change TextMessageContentEvent to TextMessageChunkEvent in test to match actual AG-UI protocol event types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…ttranslator Add test for ADK streaming fallback branch
…e for streaming event
tylerslaton
requested review from
mme,
ranst91,
ataibarkai,
maxkorp and
NathanTarbert
as code owners
|
@tylerslaton I see the failures - I'll take a look this evening. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing #471