Skip to content

Conversation

contextablemark
Copy link
Contributor

@contextablemark contextablemark commented Oct 10, 2025

Addresses #516

Summary

  • ensure the ADK middleware always awaits Runner.close so toolsets are cleaned up after executions
  • add regression tests that assert the runner is closed on both successful runs and error paths

https://chatgpt.com/codex/tasks/task_e_68e96a283af883218ee21ed01db50545

@maxkorp maxkorp merged commit 9a47ff8 into ag-ui-protocol:main Oct 13, 2025
16 of 39 checks passed
@trend-denny-lee
Copy link

@contextablemark
https://deepwiki.com/search/when-is-close-called-on-the-ad_f1de0a1d-3bee-47db-ade4-ebeec7564223
The close() method on the ADK Runner is NOT called on each request. Instead, runners are cached and reused across requests, and close() is only called when the app shuts down or when a runner needs to be reloaded.

@contextablemark contextablemark deleted the codex/address-issue-516-in-ag-ui branch October 14, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants