feat: add http.Flusher fallback for SSEWriter in Golang SDK #560
+53
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsp1290
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
🔥 thanks for looking into this! @tylerslaton or @maxkorp could you run the workflows to make sure everything is passing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing SSEWriter flushing expected the custom flusher interface that returns an error, but standard http.Flusher exposes a Flush method with no return value, so SSE responses using that type were not flushed; this change adds explicit support for the http.Flusher path and exercises both WriteEvent and WriteBytes to confirm the SSE payload reaches clients when only http.Flush is available.