fix(adk-middleware): filter empty text events to prevent frontend crash #746
+140
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AG-UI's TextMessageContentEvent validates that delta is non-empty. When ADK yielded events with empty string content, the validation would fail and crash the frontend. Added early return in _translate_text_content when combined_text is empty, preventing the creation of TextMessageContentEvent with empty delta. Added comprehensive tests for empty text event handling: - test_empty_text_event_does_not_crash - test_whitespace_only_text_event_does_not_crash - test_multiple_empty_parts_filtered - test_mixed_empty_and_valid_parts_filtering - test_empty_combined_text_early_return
contextablemark
merged commit 6cb52c3
into
ag-ui-protocol:contextablemark/test745
11 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AG-UI's TextMessageContentEvent validates that delta is non-empty. When ADK yielded events with empty string content, the validation would fail and crash the frontend.
Added early return in _translate_text_content when combined_text is empty, preventing the creation of TextMessageContentEvent with empty delta.
Added comprehensive tests for empty text event handling: