Draft
Conversation
added 2 commits
August 12, 2025 14:49
|
Jack Mayo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
Hi! Looks not so bad. Which LLM model did u use? |
Author
Claude Code, mainly opus, it needs fixing though there are a couple of issues I can see after first human pass. |
added 8 commits
August 12, 2025 18:24
Lancetnik
reviewed
Aug 14, 2025
Lancetnik
reviewed
Aug 14, 2025
| self, | ||
| topic: Annotated[ | ||
| str, | ||
| Doc("Topic name to publish messages to"), |
Member
There was a problem hiding this comment.
We are on the road to remove all Doc usages. Please, use regular docstrings instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the gcppubsub broker via the gcloud-aio library
Closes #1229
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis