Conversation
|
@Lancetnik Hi! I also have a question: after my changes, a lot of tests started failing because they assert the exact payload output, like this: assert len(payload) == 1
key, value = next(iter(payload.items()))
assert key == "User"
assert value == {
"properties": IsDict({
"id": {"title": "Id", "type": "integer"},
"email": {"default": "", "title": "Email", "type": "string"},
})
| IsDict({
"id": {"title": "Id", "type": "integer"},
"name": {"default": "", "title": "Name", "type": "string"},
}),
"required": ["id"],
"title": key,
"type": "object",
}The failures are caused by the fact that I added a new payload to the output. Do you think it makes sense to update all these tests, or is there a better way to handle this? |
|
@stefan-vasilenko thank you! At first look everything looks fine. Let me check in details, what we can make with failing tests |
|
Sorry, for long inactive I was back to this feature and will complete it |
|
@stefan-vasilenko sorry, it's my bad! Seems like the last thing we need to do - review. Can you just fix CI to let me investigate the feature? |
|
Of course, wait my commits! |
Description
Added reply generation to AsyncApi scheme v3.0.0
Fixes #1586
Type of change
Please delete options that are not relevant.
Checklist
just lintshows no errors)just test-coveragejust static-analysis