append only valid key=value lines for agama.conf#2202
append only valid key=value lines for agama.conf#2202olafhering wants to merge 1 commit intoagama-project:masterfrom
Conversation
inst.info=URL allows to retrieve agama settings from a remote location. Usually the expected settings are in key=value format. This change allows to reuse the inst.info=URL feature for the cobbler "nopxe" API, just like it is done in linuxrc. The system needs to notify cobbler that it booted "far enough", so that cobbler can change the boot loader default from "boot from network" to "boot from local disk". The client has to send a HTTP GET request to the specified URL. cobbler sends the four bytes 'True' in return, which can system has to ignore. Since the content is not and can not be a valid Agama key=value pair, consider only lines that contain '=' in the input file. Fixes agama-project#2185 Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
There are some options that do not have any value and there might be even more in the future, for example
See https://agama-project.github.io/docs/user/boot_options and https://agama-project.github.io/docs/user/boot_options/linuxrc_compatibility |
|
The = for password could be easily enforced, and Y2DEBUG could be specified by kernel cmdline, if really required. |
|
question is if we should abuse info param as in past or better have dedicated support in agama with something like |
|
Well, the client can not do anything about whatever it receives. The point is that it needs to send a GET request, and it needs to deal with any content, by just ignoring it. |
inst.info=URL allows to retrieve agama settings from a remote location. Usually the expected settings are in key=value format.
This change allows to reuse the inst.info=URL feature for the cobbler "nopxe" API, just like it is done in linuxrc. The system needs to notify cobbler that it booted "far enough", so that cobbler can change the boot loader default from "boot from network" to "boot from local disk". The client has to send a HTTP GET request to the specified URL. cobbler sends the four bytes 'True' in return, which can system has to ignore. Since the content is not and can not be a valid Agama key=value pair, consider only lines that contain '=' in the input file.
Fixes #2185