Make curl dependency for agama-network optional via feature#3332
Open
jcronenberg wants to merge 1 commit intoagama-project:masterfrom
Open
Make curl dependency for agama-network optional via feature#3332jcronenberg wants to merge 1 commit intoagama-project:masterfrom
jcronenberg wants to merge 1 commit intoagama-project:masterfrom
Conversation
Due to a dependency chain agama-network pulls in curl via agama-network -> agama-utils -> agama-transfer -> curl. With this comes a dependency on openssl which unfortunately for wicked2nm is a problem, because it fails to build on older SLE 15 SPs. To circumvent this I added a default feature that excludes the affected parts from agama-network so it doesn't depend on agama-transfer. This should have no actual impact on agama itself.
jcronenberg
force-pushed
the
optional_curl
branch
from
43e52cb to
b843c2a
Compare
jcronenberg
changed the title
Contributor
Author
|
Btw I decided to skip adding a changelog to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Due to a dependency chain agama-network pulls in curl via agama-network -> agama-utils -> agama-transfer -> curl. With this comes a dependency on openssl which unfortunately for wicked2nm is a problem, because it fails to build on older SLE 15 SPs.
Solution
To circumvent this I added a default feature that excludes the affected parts from agama-network so it doesn't depend on agama-transfer.
This should have no actual impact on agama itself.