Conversation
JacquesCarette
left a comment
There was a problem hiding this comment.
Very nice! I want to explore some potential changes. But while I say 'Request changes', what I really mean is "let's discuss the design some more". This is definitely a great contribution.
| P⊗ .identity (x , y) = refl | ||
|
|
||
| P⊗ .homomorphism {f = f₁ , f₂} (x₁ , x₂) | ||
| with f₁ x₁ | f₂ x₂ |
There was a problem hiding this comment.
we've used very little with in agda-categories up until now. It's fragile. I do realize that for dealing with partial functions, it is a powerful tool.
What I'm wondering is if the "pattern of reasoning" going on here could be abstracted out and used here?
| } | ||
|
|
||
| PM⊗ .unitorˡ-commute-from {f = f} (lift tt , x) | ||
| with f x |
There was a problem hiding this comment.
here I definitely would like to see this kind of reasoning abstracted out!
src/Categories/Category/Monoidal/Instance/PartialFunctions.agda
Outdated
Show resolved
Hide resolved
src/Categories/Category/Monoidal/Instance/PartialFunctions.agda
Outdated
Show resolved
Hide resolved
src/Categories/Category/Monoidal/Instance/PartialFunctions.agda
Outdated
Show resolved
Hide resolved
src/Categories/Category/Monoidal/Instance/PartialFunctions.agda
Outdated
Show resolved
Hide resolved
|
I'd maybe rename |
I know the more general notion of "partial functions" is |
|
I agree that consistency is very important. In the absence of other forces, I would always let consistency win. In this case: I agree with @TOTBWF that this is a bad name. So I would like to find a better name -- and then I will change |
Introduce Sets and PartialFunctions as rig categories.