-
Notifications
You must be signed in to change notification settings - Fork 257
Factor antisymmetry proof for sublist #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c6f7f4
to
94e2bfb
Compare
src/Data/List/Relation/Binary/Sublist/Heterogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that looks good to me!
src/Data/List/Relation/Binary/Sublist/Heterogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks (mostly cosmetic), but using implicits/variables makes proofs more robust (I think!?)
src/Data/List/Relation/Binary/Sublist/Heterogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
src/Data/List/Relation/Binary/Sublist/Heterogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
src/Data/List/Relation/Binary/Sublist/Heterogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
@andreasabel I would merge with my suggestions, unless you feel strongly that they make things worse? Separately, you allude to (the possibility of) a default squash/merge policy for I'd be grateful for pointers to how to understand the trade offs between these approaches, and what conclusions, if any, we might draw for stdlib maintenance/development? |
Co-authored-by: jamesmckinna <[email protected]>
I committed your suggestions, thanks! Merging by rebase would preserve the original commits. We do this in the Agda codebase if they are all meaningful and pass the build (and maybe the tests) individually. This can have the advantage of smaller commits too look at when bisecting which commit introduced a bug. |
Commits:
Simplify Sublist/Heterogeneous/antisym: collapse two cases:
Removes an unnecessary case split.
Simplify Sublist/Heterogeneous/antisym: factor out contradiction:
Pulls the duplicated proof into a lemma.
These can be squashed, but I worked in two steps since I am unsure about the style policy.