Skip to content

Fix/usersuite status#522

Open
FelixFelix0815 wants to merge 4 commits intodevelopfrom
fix/usersuite_status
Open

Fix/usersuite status#522
FelixFelix0815 wants to merge 4 commits intodevelopfrom
fix/usersuite_status

Conversation

@FelixFelix0815
Copy link
Contributor

You're opening a pull request? Awesome!

Please make sure though you did the following (tick off everything you
already did):

  • [ ✅] Run the tests and see them pass
  • [✅ ] Rebase your branch on top of develop
  • [ ✅] Include tests for features you introduced / bugs you fixed

This issue fixes #482

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.58%. Comparing base (3221b37) to head (308f5a1).

Files with missing lines Patch % Lines
tests/model/test_user.py 96.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #522      +/-   ##
===========================================
+ Coverage    29.14%   29.58%   +0.44%     
===========================================
  Files           71       71              
  Lines         8454     8534      +80     
===========================================
+ Hits          2464     2525      +61     
- Misses        5990     6009      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FelixFelix0815 FelixFelix0815 requested a review from agmes4 February 4, 2026 19:58
@lukasjuhrich
Copy link
Collaborator

Thank you for tackling this!

Just had the time to skim, tomorrow I can take a closer look:
Please write the tests in pytest.
It gives much nicer ergonomics (fixtures instead of setup methods, parametrization) which will generally improve readability and maintainability of the tests.
I can tell you more tomorrow at Wu5 Office if you want some in person guidance.

P.S. sorry that this ActiveProperty nonsense still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Wording when no network host exist

2 participants