Skip to content

Handle circuit breaker rollbacks #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle circuit breaker rollbacks #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad00830
Handle circuit breaker rollbacks
LouisBoudreau Jan 4, 2024
1a72586
Fix test name
LouisBoudreau Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion __tests__/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ describe("waitForDeploymentOutcome", () => {
const deploymentB = {
id: "2",
status: DeploymentStatus.PRIMARY,
taskDefinitionArn: TASK_DEFINITION_ARN.slice(0, -1),
taskDefinitionArn: TASK_DEFINITION_ARN + "1",
rolloutState: RolloutState.IN_PROGRESS
};
const finalDeploymentsState = [{ ...deploymentA }, { ...deploymentB }];
Expand All @@ -136,6 +136,37 @@ describe("waitForDeploymentOutcome", () => {
).toBe(DeploymentOutcome.SKIPPED);
});

test("It must return 'rollback' if a rollback enqueued", async () => {
const deploymentA = {
id: "1",
status: DeploymentStatus.PRIMARY,
taskDefinitionArn: TASK_DEFINITION_ARN,
rolloutState: RolloutState.IN_PROGRESS
};
const initialDeploymentsState = [{ ...deploymentA }];
mockedFetchDeployments = mockedFetchDeployments.mockReturnValueOnce(initialDeploymentsState);

deploymentA.status = DeploymentStatus.ACTIVE;
const deploymentB = {
id: "2",
status: DeploymentStatus.PRIMARY,
taskDefinitionArn: TASK_DEFINITION_ARN.slice(0, -1),
rolloutState: RolloutState.IN_PROGRESS
};
const finalDeploymentsState = [{ ...deploymentA }, { ...deploymentB }];
mockedFetchDeployments = mockedFetchDeployments.mockReturnValueOnce(finalDeploymentsState);

expect(
await waitForDeploymentOutcome(
CLUSTER,
SERVICE,
TASK_DEFINITION_ARN,
setTimeout(() => {}),
1
)
).toBe(DeploymentOutcome.ROLLBACK);
});

test("It must timeout service deployment never becomes stable", async () => {
const deployments = [
{
Expand Down
Loading