Conversation
Centralizes knowledge base in agent-sh/agent-knowledge repo, shared across all plugin repos via submodule.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the agent-knowledge repository as a git submodule to centralize a shared knowledge base. No security vulnerabilities were found. However, there is an opportunity to improve the submodule configuration for better portability and developer experience by using a relative URL instead of a hardcoded HTTPS URL.
| @@ -0,0 +1,3 @@ | |||
| [submodule "agent-knowledge"] | |||
| path = agent-knowledge | |||
| url = https://github.com/agent-sh/agent-knowledge.git | |||
There was a problem hiding this comment.
For better portability and to accommodate different protocols (HTTPS/SSH) that developers might use, it's recommended to use a relative URL for the submodule. This allows developers to clone the superproject with either SSH or HTTPS, and the submodule will use the same protocol. This also makes it easier to work with forks of the repository.
url = ../agent-knowledge.git
Summary
agent-knowledgeas a git submodule pointing toagent-sh/agent-knowledgeTest plan
git submodule update --initworks after cloneagent-knowledge/