fix: normalize string entries in loadComponents to prevent padEnd crash#273
Merged
avifenesh merged 1 commit intoagent-sh:mainfrom Mar 1, 2026
Merged
Conversation
`agentsys list` commands crash with "Cannot read properties of undefined
(reading 'padEnd')" because components.json stores entries as plain
strings while the display code expects objects with a .name property.
Normalize string entries to {name} objects when loading from JSON.
Collaborator
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avifenesh
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentsys list --all,--agents,--skills, and--commandscrash withCannot read properties of undefined (reading 'padEnd')becauseloadComponents()returns raw string entries fromcomponents.jsonwhile the display code expects objects with a.nameproperty{name}objects inloadComponents()so both string and object entries are handled correctlyTest plan
agentsys list --agentslists all 32 agents without erroragentsys list --skillslists all 30 skills without erroragentsys list --commandslists all 19 commands without erroragentsys list --allshows everything without error