Skip to content

fix: disable CDX-AG-002 agnix rule — 'Token efficiency' false positive#22

Merged
avifenesh merged 1 commit intomainfrom
fix/agnix-cdx-ag-002-false-positive
Mar 25, 2026
Merged

fix: disable CDX-AG-002 agnix rule — 'Token efficiency' false positive#22
avifenesh merged 1 commit intomainfrom
fix/agnix-cdx-ag-002-false-positive

Conversation

@agent-cairn
Copy link
Copy Markdown
Collaborator

Agnix CI fails on main with CDX-AG-002: Potential secret detected in AGENTS.md. The trigger is the text 'Token efficiency' which is not a secret — it's an ecosystem-wide boilerplate instruction from agent-core sync.

This adds CDX-AG-002 to disabled_rules with a comment explaining the false positive, matching the pattern already used in agent-sh/agentsys.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a recurring CI failure on the main branch caused by the CDX-AG-002 AgniX rule. The rule incorrectly identified the phrase "Token efficiency" in AGENTS.md as a potential secret, despite it being a standard boilerplate instruction. By disabling this specific rule, the change ensures the CI pipeline passes without flagging legitimate, non-secret content, aligning with existing patterns for handling similar false positives.

Highlights

  • AgniX CI Fix: Disabled the CDX-AG-002 AgniX rule to resolve a false positive detection of "Token efficiency" as a secret in AGENTS.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the CDX-AG-002 rule in agnix to resolve a false positive secret detection in AGENTS.md. While this fixes the immediate CI failure, I've raised a concern about disabling a security rule globally. My feedback suggests exploring a more scoped-down approach to disabling the rule, if the tool supports it, to avoid potentially missing real secrets in the future.

"CC-SK-017", # Intentional - version is a client-specific frontmatter field
"XP-003", # Intentional - lib/cross-platform/RESEARCH.md documents all platform paths
"CC-MEM-004", # npm validate referenced in auto-generated CLAUDE.md (agent-core template issue)
"CDX-AG-002", # False positive - "Token efficiency" in AGENTS.md is not a secret
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Disabling a secret detection rule globally for the entire repository can be a security risk, as it may prevent the detection of actual secrets committed in other files in the future. A more secure approach is to scope the exception as narrowly as possible. If agnix supports a more granular configuration, please consider disabling this rule only for AGENTS.md to limit the scope of this exception.

@agent-cairn agent-cairn marked this pull request as ready for review March 24, 2026 23:52
@avifenesh avifenesh merged commit 32e88b2 into main Mar 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants