fix: disable CDX-AG-002 agnix rule — 'Token efficiency' false positive#19
fix: disable CDX-AG-002 agnix rule — 'Token efficiency' false positive#19agent-cairn wants to merge 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a continuous integration failure caused by the AgniX security scanner. It specifically targets a false positive where the phrase "Token efficiency" was incorrectly identified as a secret. The change prevents future CI failures by explicitly disabling the problematic rule for this specific false positive. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request disables the CDX-AG-002 agnix rule to resolve a false positive secret detection in AGENTS.md. The change is appropriate for fixing the CI failure. I have added one suggestion to sort the list of disabled rules alphabetically to improve maintainability.
| "CC-SK-017", # Intentional - version is a client-specific frontmatter field | ||
| "XP-003", # Intentional - lib/cross-platform/RESEARCH.md documents all platform paths | ||
| "CC-MEM-004", # npm validate referenced in auto-generated CLAUDE.md (agent-core template issue) | ||
| "CDX-AG-002", # False positive - "Token efficiency" in AGENTS.md is not a secret |
There was a problem hiding this comment.
To improve maintainability and make it easier to find rules in the future, please keep this list sorted alphabetically.
| "CC-SK-017", # Intentional - version is a client-specific frontmatter field | |
| "XP-003", # Intentional - lib/cross-platform/RESEARCH.md documents all platform paths | |
| "CC-MEM-004", # npm validate referenced in auto-generated CLAUDE.md (agent-core template issue) | |
| "CDX-AG-002", # False positive - "Token efficiency" in AGENTS.md is not a secret | |
| "CC-MEM-004", # npm validate referenced in auto-generated CLAUDE.md (agent-core template issue) | |
| "CC-SK-017", # Intentional - version is a client-specific frontmatter field | |
| "CDX-AG-002", # False positive - "Token efficiency" in AGENTS.md is not a secret | |
| "XP-003", # Intentional - lib/cross-platform/RESEARCH.md documents all platform paths |
Agnix CI fails on main with
CDX-AG-002: Potential secret detected in AGENTS.md. The trigger is the text 'Token efficiency' which is not a secret — it's an ecosystem-wide boilerplate instruction from agent-core sync.This adds CDX-AG-002 to disabled_rules with a comment explaining the false positive, matching the pattern already used in agent-sh/agentsys.