remove dependency on ACP #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usage Add example showing how to create a minimal ACP agent using the sacp JsonRpcConnection API. Demonstrates handling initialize request and routing other messages through untyped handler.
…tocol-schema Updated all crates to depend on agent-client-protocol-schema (v0.6.3) instead of the full agent-client-protocol package. This makes the sacp crate more standalone by only depending on the schema definitions. Changes: - Updated workspace dependency to [email protected] - Updated all crate Cargo.toml files (sacp, sacp-proxy, sacp-conductor) - Replaced all import statements across the codebase - Verified build and all tests pass (32 tests)
Renamed all JsonRpc-prefixed types to Jr (JSON-RPC) prefix: - JsonRpcConnection → JrConnection - JsonRpcConnectionCx → JrConnectionCx - JsonRpcHandler → JrHandler - JsonRpcMessage → JrMessage - JsonRpcRequest → JrRequest - JsonRpcNotification → JrNotification - JsonRpcRequestCx → JrRequestCx - JsonRpcResponse → JrResponse - JsonRpcResponsePayload → JrResponsePayload This prepares for extracting the generic JSON-RPC handling into a separate 'jr' crate that is not tied to the Agent Client Protocol. All tests pass (32 tests across sacp, sacp-proxy, sacp-conductor). Co-authored-by: Claude <[email protected]>
Re-export all types from agent-client-protocol-schema at the root of sacp. This makes ACP protocol types directly available as sacp::InitializeRequest, sacp::SessionId, etc. without requiring users to import from both crates. No naming conflicts detected - the Jr* rename resolved the only conflict (JrMessage trait vs agent-client-protocol-schema's JsonRpcMessage struct). All tests pass (32 tests across sacp, sacp-proxy, sacp-conductor). Co-authored-by: Claude <[email protected]>
Replace agent_client_protocol_schema imports and acp:: usages: - Within sacp: use crate:: to reference re-exported types - In sacp-proxy/conductor: use sacp:: instead of acp:: - In tests and examples: use sacp:: instead of acp:: This makes the code clearer by using the actual source (sacp) for all ACP types, now that sacp re-exports them all. All 32 tests pass. Co-authored-by: Claude <[email protected]>
Replace incorrect crate::Error references with sacp::Error in sacp-proxy, sacp-conductor, and test files. The Error type is defined in sacp and should be referenced as sacp::Error from other crates. Also remove unused 'self as acp' imports from agent_client_protocol_schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch
agent-client-protocolwith a dependency onagent-client-protocol-schema