Print layout-field-preview before children#1438
Open
fredrikkarlsson-pervanovo wants to merge 1 commit intoagentejo:nextfrom
Open
Print layout-field-preview before children#1438fredrikkarlsson-pervanovo wants to merge 1 commit intoagentejo:nextfrom
fredrikkarlsson-pervanovo wants to merge 1 commit intoagentejo:nextfrom
Conversation
Contributor
Author
|
Before PR: After PR: |
fredrikkarlsson-pervanovo
force-pushed
the
pr-layout-preview-before-children
branch
from
8289adb to
db65a03
Compare
fredrikkarlsson-pervanovo
force-pushed
the
pr-layout-preview-before-children
branch
2 times, most recently
from
fb0a33f to
47b3198
Compare
Contributor
Author
|
Rebased this to be easily merged |
fredrikkarlsson-pervanovo
force-pushed
the
pr-layout-preview-before-children
branch
from
47b3198 to
cb584cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have added layout component previews for parent elements (ie. having children) and then it makes more sense to have the preview up on top with the heading instead of below the children with the add button.
This PR simply moves the layout component preview area to be printed before the children.