-
Notifications
You must be signed in to change notification settings - Fork 18
fix(graders): fix typo in code_execution filename and imports #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Rename code_excution.py to code_execution.py (fix typo) - Fix imports in code/__init__.py: open_judge -> openjudge - Remove commented-out import in base_grader.py
Summary of ChangesHello @XiaoBoAI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code hygiene and correctness by addressing several minor issues. It primarily fixes a typo in a filename and updates corresponding import paths, alongside removing a redundant commented-out line of code. These changes improve code consistency and maintainability without altering functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides several useful cleanups, including fixing a typo in a filename, standardizing the package name in imports, and removing commented-out code. The changes are correct and improve code quality. I have one suggestion regarding the use of relative imports in openjudge/graders/code/__init__.py to improve conciseness, which you can find in the detailed comments. Overall, this is a good set of fixes.
- Fix doctest examples to use proper subclass instantiation - Add type hints to concurrency.py run_with_concurrency_control - Support list templates in LLMGrader initialization - Fix DashScope formatter to handle empty lists correctly - Improve PromptTemplate error messages for missing languages - Use more specific exception types in utils modules - Update test assertion for new template error message
OpenJudge Version
[The version of OpenJudge you are working on, e.g.
import openjudge; print(openjudge.__version__)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
pre-commit run --all-filescommand