Skip to content

Fix vllm nccl sync error #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenyushuo merged 2 commits into from
Jul 21, 2025
Merged

Fix vllm nccl sync error #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af29ec7
fix vllm nccl sync
pan-x-c Jul 21, 2025
9c9be1d
fix pre-commit
pan-x-c Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions trinity/trainer/verl/fsdp_workers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
import torch
import torch.distributed
import torch.distributed as dist

# import vllm # noqa: F401 ; import vllm to set NCCL_CUMEM_ENABLE automatically.
import vllm # noqa: F401 ; import vllm to set NCCL_CUMEM_ENABLE automatically.
from codetiming import Timer
from omegaconf import DictConfig, OmegaConf, open_dict
from peft import LoraConfig, TaskType, get_peft_model
Expand Down