Skip to content

Minor updates for BOTS example #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HYLcool merged 1 commit into from
Nov 14, 2025
Merged

Minor updates for BOTS example #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/bots/workflow/bots_math_boxed_reward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from trinity.common.rewards.reward_fn import REWARD_FUNCTIONS, RewardFn
from trinity.utils.eval_utils import validate_think_pattern

from .bots_reward import compute_score


@REWARD_FUNCTIONS.register_module("bots_math_boxed_reward")
class BOTSMathBoxedRewardFn(RewardFn):
Expand All @@ -24,6 +22,8 @@ def __call__( # type: ignore
format_score_coef: Optional[float] = 0.1,
**kwargs,
) -> dict[str, float]:
from trinity.plugins.bots_reward import compute_score

accuracy_score = compute_score(response, truth)

format_score = 0.0
Expand Down
16 changes: 4 additions & 12 deletions examples/bots/workflow/bots_math_boxed_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,23 @@
from trinity.common.workflows.customized_math_workflows import MathBoxedWorkflow, Task
from trinity.common.workflows.workflow import WORKFLOWS

from .bots_math_boxed_reward import BOTSMathBoxedRewardFn


@WORKFLOWS.register_module("bots_math_boxed_workflow")
class BOTSMathBoxedWorkflow(MathBoxedWorkflow):
"""A workflow for math tasks that give answers in boxed format for BOTS."""

def reset(self, task: Task):
super().reset(task)
from trinity.plugins.bots_math_boxed_reward import BOTSMathBoxedRewardFn

self.reward_fn = BOTSMathBoxedRewardFn(**self.reward_fn_args)
self.task_desc = nested_query(self.format_args.prompt_key, self.raw_task)
self.truth = nested_query(self.format_args.response_key, self.raw_task)

def format_messages(self):
# the prompts are already in message format
return self.task_desc

@property
def task_desc(self) -> Union[str, None]: # type: ignore [override]
prompt_key = self.format_args.prompt_key
return nested_query(prompt_key, self.raw_task) # type: ignore

@property
def truth(self) -> Union[str, None]: # type: ignore [override]
response_key = self.format_args.response_key
return nested_query(response_key, self.raw_task)


def nested_query(query_key: str, query_obj: Union[dict, None]):
# support nested query for a dict given query_keys split by '.'
Expand Down