Skip to content

Add config_validator.py and refactor config #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-x-c merged 9 commits into from
Jan 26, 2026
Merged

Add config_validator.py and refactor config #487

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cb4cd2c
Add `config_validator.py` and refactor config
chenyushuo Jan 22, 2026
e47dd24
add allocation info to `ClusterConfig`
chenyushuo Jan 22, 2026
b0e4171
add docstring to `config_validator.py`
chenyushuo Jan 22, 2026
05672c7
apply reviews
chenyushuo Jan 22, 2026
cebd16f
fix unittest
chenyushuo Jan 23, 2026
9874d5c
fix unittest
chenyushuo Jan 23, 2026
cfb0847
1. fix unittest
chenyushuo Jan 23, 2026
46cfac8
add gc.collect to ray unittest
chenyushuo Jan 23, 2026
cdd9eeb
Merge branch 'main' of github.com:modelscope/Trinity-RFT into ref/ref…
chenyushuo Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/common/config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_update_config_from_ray_cluster(self):
config.cluster.node_num = None
config.cluster.gpu_per_node = None

config._update_config_from_ray_cluster()
config.check_and_update()
self.assertEqual(config.cluster.node_num, 2)
self.assertEqual(config.cluster.gpu_per_node, 2)

Expand Down
Loading