feat(transport): Set connection pool for jdk http client #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
AlbumenJ
requested changes
Jan 8, 2026
agentscope-core/src/main/java/io/agentscope/core/model/transport/JdkHttpTransport.java
Outdated
Show resolved
Hide resolved
guanxuc
force-pushed
the
jdk-httpclient-connection-pool
branch
from
e0b332a to
afe0f55
Compare
AlbumenJ
approved these changes
Jan 9, 2026
AlbumenJ
reviewed
Jan 9, 2026
Comment on lines
+109
to
+111
| System.setProperty( | ||
| "jdk.httpclient.connectionPoolSize", | ||
| String.valueOf(config.getMaxIdleConnections())); |
Collaborator
There was a problem hiding this comment.
I'm a bit concerned that this might affect other parts of the user's application that use the JDK HTTP Client.
Contributor
Author
There was a problem hiding this comment.
You're right, maybe it will be better that the properties be configured by user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.7-SNAPSHOT
Description
Set connection pool for jdk http client
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)