fix: invoke print hooks before console output check#1328
Open
KJyang-0114 wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix: invoke print hooks before console output check#1328KJyang-0114 wants to merge 1 commit intoagentscope-ai:mainfrom
KJyang-0114 wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
This fixes the issue where set_console_output_enabled(False) also disabled AgentScope Studio forwarding. Now pre_print and post_print hooks are invoked BEFORE the console output check, allowing Studio to receive messages even when console output is disabled. This decouples Studio/tracing from console output, enabling users to: - Disable console logs in production - Keep Studio/tracing enabled for observability Fixes agentscope-ai#1149
|
Coder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes issue #1149 where
set_console_output_enabled(False)also disabled AgentScope Studio forwarding.Root Cause
The
print()method inAgentBasechecked_disable_console_outputand returned early before any hooks were invoked. This meant the Studio pre_print hook never ran when console output was disabled.Fix
Invoke
pre_printandpost_printhooks before the console output check. This decouples Studio/tracing from console output:set_console_output_enabled(False)now only disables console printingChanges
src/agentscope/agent/_agent_base.py:pre_printhooks before the early returnpost_printhooks after console output (but before cleanup)Testing
Risk
Rollback
Simply revert this commit to restore previous behavior.