Conversation
joanestebanr
approved these changes
Feb 5, 2026
joanestebanr
reviewed
Feb 5, 2026
| networkConfigDeprecatedHint = "NetworkConfig is deprecated, use L1NetworkConfig instead" | ||
| l1NetworkConfigUsePolTokenAddrHint = "Use L1NetworkConfig.POLTokenAddr instead" | ||
| l1NetworkConfigUseRollupAddrHint = "Use L1NetworkConfig.RollupAddr instead" | ||
| delayBetweenRetriesHint = "AggSender.DelayBeetweenRetries is deprecated, " + |
Collaborator
There was a problem hiding this comment.
You don't have to modify this line, this was a previous fix typo.
In any case you can add a new entry:
AggSender.TriggerASAP.DelayBeetweenRetries-> AggSender.TriggerASAP.DelayBetweenCertificates
But I think that is not required because v0.9.0-rc1 introduce this config parameter
| AggchainProofURL = "http://localhost:5576" | ||
| UseAggkitProverTLS = true | ||
| GenerateAggchainProofTimeout = "1h" | ||
| DelayBeetweenRetries = "1s" |
Collaborator
There was a problem hiding this comment.
You have to revert this change: This is a test to check that deprecated entries as detected, so must have the typo
joanestebanr
added a commit
that referenced
this pull request
Feb 5, 2026
## 🔄 Changes Summary - Fix typo: `AggSender.TriggerASAP.DelayBeetweenCertificates` ##⚠️ Breaking Changes - Deprecated field ` `AggSender.TriggerASAP.DelayBeetweenCertificates` in favour of `DelayBetweenCertificates` DelayBetweenCertificates = "1s" ``` [AggSender.TriggerASAP] ``` ## 📋 Config Updates - 🧾 **Diff/Config snippet**: [Optional: Enumerate config changes/provide snippet of changes] ## 🔗 Related PRs - #1470 --------- Signed-off-by: Ji Hwan <jkim@polygon.technology> Co-authored-by: Ji Hwan <jkim@polygon.technology>
joanestebanr
added a commit
that referenced
this pull request
Feb 5, 2026
## 🔄 Changes Summary - Fix typo: `AggSender.TriggerASAP.DelayBeetweenCertificates` ##⚠️ Breaking Changes - Deprecated field ` `AggSender.TriggerASAP.DelayBeetweenCertificates` in favour of `DelayBetweenCertificates` DelayBetweenCertificates = "1s" ``` [AggSender.TriggerASAP] ``` ## 📋 Config Updates - 🧾 **Diff/Config snippet**: [Optional: Enumerate config changes/provide snippet of changes] ## 🔗 Related PRs - #1470 --------- Signed-off-by: Ji Hwan <jkim@polygon.technology> Co-authored-by: Ji Hwan <jkim@polygon.technology>
Collaborator
|
This PR have moved to a new PR #1471 |
joanestebanr
added a commit
that referenced
this pull request
Feb 5, 2026
Cherry-pick from `develop` #1471 ## 🔄 Changes Summary - Fix typo: `AggSender.TriggerASAP.DelayBeetweenCertificates` ##⚠️ Breaking Changes - Deprecated field ` `AggSender.TriggerASAP.DelayBeetweenCertificates` in favour of `DelayBetweenCertificates` DelayBetweenCertificates = "1s" ``` [AggSender.TriggerASAP] ``` ## 📋 Config Updates - 🧾 **Diff/Config snippet**: [Optional: Enumerate config changes/provide snippet of changes] ## 🔗 Related PRs - #1470 Signed-off-by: Ji Hwan <jkim@polygon.technology> Co-authored-by: Ji Hwan <jkim@polygon.technology>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Changes Summary
-fix typo
DelayBeetweenCertificates->DelayBetweenCertificatesto pass spellcheck CI in Kurtosis-CDK