Skip to content

chore: bump go to 1.25.7 (fix vulnerability)#1475

Open
joanestebanr wants to merge 1 commit intodevelopfrom
fix/vulncheck-go_1_25_6
Open

chore: bump go to 1.25.7 (fix vulnerability)#1475
joanestebanr wants to merge 1 commit intodevelopfrom
fix/vulncheck-go_1_25_6

Conversation

@joanestebanr
Copy link
Collaborator

🔄 Changes Summary

Bump go to 1.25.7

Vulnerability #1: GO-2026-4337
    Unexpected session resumption in crypto/tls
  More info: https://pkg.go.dev/vuln/GO-2026-4337
  Standard library
    Found in: crypto/tls@go1.25.6
    Fixed in: crypto/tls@go1.25.7
    Example traces found:
Error:       #1: prometheus/prometheus.go:39:13: prometheus.Init calls sync.Once.Do, which eventually calls tls.Conn.Handshake
Error:       #2: pprof/pprof.go:66:33: pprof.StartProfilingHTTPServer calls http.Server.Serve, which eventually calls tls.Conn.HandshakeContext
Error:       #3: bridgeservice/client/client.go:368:29: client.Client.doRequest calls io.ReadAll, which eventually calls tls.Conn.Read
Error:       #4: version.go:20:13: aggkit.PrintVersion calls fmt.Fprintf, which calls tls.Conn.Write
Error:       #5: bridgeservice/client/client.go:362:30: client.Client.doRequest calls http.Client.Do, which eventually calls tls.Dialer.DialContext

Your code is affected by 1 vulnerability from the Go standard library.
This scan found no other vulnerabilities in packages you import or modules you

@joanestebanr joanestebanr self-assigned this Feb 6, 2026
@claude
Copy link

claude bot commented Feb 6, 2026

Claude finished @joanestebanr's task in 1m 13s —— View job


🔍 PR Review Complete

Todo List

  • Gather context: Review PR changes against develop branch
  • Examine modified files for consistency
  • Verify Go version upgrade is applied correctly across all files
  • Check for potential issues or improvements
  • Provide structured review feedback

🚀 What's New

This PR upgrades Go from version 1.25.6 to 1.25.7 to address a critical security vulnerability (GO-2026-4337) in the crypto/tls standard library package. The vulnerability involves unexpected session resumption in TLS connections. The version bump is consistently applied across all GitHub Actions workflows, the Dockerfile, and go.mod.

🐛 Bug Fixes

None - This is purely a security patch upgrade.

📋 Config Updates

  • go.mod: go 1.25.6go 1.25.7 (line 3)
  • Dockerfile: FROM golang:1.25.6-alpineFROM golang:1.25.7-alpine (line 4)
  • GitHub Workflows: All workflow files updated to use Go 1.25.7:
    • .github/workflows/codeql.yml: go-version: 1.25.7 (line 39)
    • .github/workflows/govulncheck.yml: go-version-input: 1.25.7 (line 17)
    • .github/workflows/lint.yml: go-version: 1.25.7 (line 22)
    • .github/workflows/test-e2e.yml: go-version: 1.25.7 (lines 62, 160)
    • .github/workflows/test-unit.yml: go-version: [1.25.7] (line 22)

⚠️ Breaking Changes

None


📊 Review Analysis

✅ Strengths

🟢 Consistent Version Updates: The Go version has been correctly updated across all 7 files. No missed locations.

🟢 Security Fix: Addresses a legitimate security vulnerability in the Go standard library's TLS implementation. The govulncheck workflow shows it passed successfully, confirming the vulnerability is resolved.

🟢 Minimal Scope: This PR correctly focuses only on the version bump without introducing unrelated changes.

🟢 Clear Documentation: The PR description includes the vulnerability details and example traces, making it easy to understand the reason for the upgrade.

🔍 Observations

🟡 Title Typo: The PR title contains a typo: "vunerability" should be "vulnerability"

🟡 CI Status: Current CI checks are running:

  • ✅ Go Vulnerability Check - PASSED (confirming the fix works)
  • ⏳ CodeQL, Lint, Unit Tests, E2E Tests - IN PROGRESS

🎯 Recommendations

  1. 🟡 Optional: Fix title typo - Consider updating the PR title to fix the spelling of "vulnerability"
  2. 🟢 Wait for CI - All critical workflows are in progress. Wait for them to complete before merging to ensure the version bump doesn't introduce any unexpected issues.

✨ Final Verdict

Status: ✅ APPROVED (pending CI completion)

This is a straightforward and necessary security patch. The implementation is correct with consistent version updates across all configuration files. The govulncheck workflow has already passed, confirming the vulnerability is resolved.

Priority Level: 🔴 Required - This addresses a security vulnerability in the standard library and should be merged once CI checks pass.

Recommendation: Merge this PR after CI workflows complete successfully.


@joanestebanr joanestebanr added the bug Something isn't working label Feb 6, 2026
@joanestebanr joanestebanr changed the title chore: bump go to 1.25.7 (fix vunerability) chore: bump go to 1.25.7 (fix vulnerability) Feb 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@joanestebanr joanestebanr enabled auto-merge (squash) February 6, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant