Skip to content

feat: split bridgesyncer into bridgesyncer + claimsyncer #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joanestebanr wants to merge 31 commits into
base: develop
Choose a base branch
from

test: if call to debug_trace would produce a fatal but for bridge

7e47af8
Select commit
Loading
Failed to load commit list.
Open

feat: split bridgesyncer into bridgesyncer + claimsyncer #1539

test: if call to debug_trace would produce a fatal but for bridge
7e47af8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 23, 2026 in 36s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.6% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 172 in sync/evmdriver.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTtK7o15W-M7lEsU&open=AZ0AWTtK7o15W-M7lEsU&pullRequest=1539

Check warning on line 203 in claimsync/types/claim_data.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTqO7o15W-M7lEsI&open=AZ0AWTqO7o15W-M7lEsI&pullRequest=1539

Check failure on line 384 in claimsync/downloader.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsk7o15W-M7lEsR&open=AZ0AWTsk7o15W-M7lEsR&pullRequest=1539

Check warning on line 75 in aggsender/prover/proof_generation_tool.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTmM7o15W-M7lEsH&open=AZ0AWTmM7o15W-M7lEsH&pullRequest=1539

Check warning on line 5 in claimsync/storage/migrations/migrations.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a comment explaining why this blank import is needed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsI7o15W-M7lEsJ&open=AZ0AWTsI7o15W-M7lEsJ&pullRequest=1539

Check warning on line 81 in claimsync/embedded.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTst7o15W-M7lEsT&open=AZ0AWTst7o15W-M7lEsT&pullRequest=1539

Check failure on line 65 in claimsync/storage/storage_paged.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "error closing rows: %v" 3 times. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsS7o15W-M7lEsK&open=AZ0AWTsS7o15W-M7lEsK&pullRequest=1539

Check warning on line 116 in bridgeservice/bridge.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTuA7o15W-M7lEsV&open=AZ0AWTuA7o15W-M7lEsV&pullRequest=1539

Check failure on line 144 in sync/evmdownloader.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 79 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0FmV3PMLjZL-UnrGnO&open=AZ0FmV3PMLjZL-UnrGnO&pullRequest=1539

Check failure on line 166 in claimsync/downloader.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsk7o15W-M7lEsQ&open=AZ0AWTsk7o15W-M7lEsQ&pullRequest=1539

Check failure on line 501 in claimsync/downloader.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsk7o15W-M7lEsS&open=AZ0AWTsk7o15W-M7lEsS&pullRequest=1539

Check warning on line 73 in grpc/server.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0LDK0XiymX4kQVcLp3&open=AZ0LDK0XiymX4kQVcLp3&pullRequest=1539

Check warning on line 98 in claimsync/downloader.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZ0AWTsk7o15W-M7lEsP&open=AZ0AWTsk7o15W-M7lEsP&pullRequest=1539
View more details on SonarQubeCloud