Skip to content

docs: enhance verifyDeployment.md documentation#423

Open
VolodymyrBg wants to merge 2 commits intoagglayer:developfrom
VolodymyrBg:AA5692BT
Open

docs: enhance verifyDeployment.md documentation#423
VolodymyrBg wants to merge 2 commits intoagglayer:developfrom
VolodymyrBg:AA5692BT

Conversation

@VolodymyrBg
Copy link

Description

This pull request improves the verifyDeployment.md documentation by fixing several typos and adding missing sections to make the verification process clearer and more comprehensive for users.

Changes made:

  1. Fixed typos:
    -Changed "DOwnload" to "Download" in the repository download section
    -Fixed the missing word in "you can the script" to "you can run the script"
    -Corrected "btyecode" to "bytecode"
    -Fixed grammar in "The script in a very similar behaviour of the last script" to "The script has a very similar behaviour to the last script"
  2. Added new sections:
    -Verifying Deployment Results: Provides clear criteria for successful verification
    -Troubleshooting: Offers guidance for common issues users might encounter during verification
  3. Improved clarity:
    -Enhanced instructions for genesis verification
    -Added more context around the verification process

@cla-bot
Copy link

cla-bot bot commented Mar 2, 2025

We require contributors/corporates @VolodymyrBg to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2025

@invocamanman
Copy link
Collaborator

lgtm, PR on develop pls

@VolodymyrBg
Copy link
Author

@invocamanman PR on develop? what i need to do?

@VolodymyrBg
Copy link
Author

@invocamanman

@krlosMata
Copy link
Member

Change the destination branch to develop.
This specific document has ben updated, please rebase with main so it has latest changes

@krlosMata
Copy link
Member

reminder: #423 (comment) xD
PR close will be closed in a few weeks if no further action is taken

@VolodymyrBg
Copy link
Author

reminder: #423 (comment) xD PR close will be closed in a few weeks if no further action is taken

Oops... sorry for the delay and thanks for reminder! gonna do it

@VolodymyrBg VolodymyrBg changed the base branch from main to develop November 7, 2025 18:10
@VolodymyrBg
Copy link
Author

reminder: #423 (comment) xD PR close will be closed in a few weeks if no further action is taken

Looks like done, sorry again for the delay, shame on me

git submodule update
sudo apt install -y build-essential libomp-dev libgmp-dev nlohmann-json3-dev libpqxx-dev nasm libgrpc++-dev libprotobuf-dev grpc-proto libsodium-dev uuid-dev libsecp256k1-dev
make -j bctree fflonkSetup
make -j bctree fflonk_setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alrevuelta to double check this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlosMata this change is correct. but note that it was already applied here https://github.com/agglayer/agglayer-contracts/pull/535/files

this PR seems to be based in an old commit, since it doesnt includes the changes of said PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants