Open
Conversation
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
from
3856a4d to
5b0d647
Compare
ignasirv
suggested changes
Aug 14, 2025
| @@ -102,22 +102,25 @@ export function valueToStorageBytes(_value) { | |||
| * Scan all SSTORE opcodes in a trace | |||
| * Does not take into account revert operations neither depth | |||
Contributor
There was a problem hiding this comment.
Whith the updated version, depth is taken into account
|
|
||
| - Copy genesis base file: | ||
| ``` | ||
| cp ./tools/createSovereignGenesis/genesis-base.json.example ./tools/createSovereignGenesis/genesis-base.json |
src/genesis-hardhat/utils.ts
Outdated
| } | ||
|
|
||
| // Get proxy transaction hash | ||
| const proxyTx = await contract.deploymentTransaction(); |
| implStorageWrites[depthTokenWrappedImpl]; | ||
| } | ||
| } catch (error) { | ||
| logger.error('Could not get Bridge implementation storage writes:', error); |
Contributor
There was a problem hiding this comment.
logging the error is not enough, the script should exit/fail. Same for other logger.error of the script
| const txDeployTimelock = await timelockContract.deploymentTransaction(); | ||
| const txDeployTimelockHash = txDeployTimelock ? txDeployTimelock.hash : undefined; | ||
|
|
||
| // Transfer ownership of the proxyAdmon to the timelock |
Contributor
There was a problem hiding this comment.
Suggested change
| // Transfer ownership of the proxyAdmon to the timelock | |
| // Transfer ownership of the proxyAdmin to the timelock |
| proxiedTokensManager, | ||
| } = initializeParams; | ||
|
|
||
| const txInitialitzeBridge = await sovereignChainBridgeContract.initialize( |
Contributor
There was a problem hiding this comment.
Suggested change
| const txInitialitzeBridge = await sovereignChainBridgeContract.initialize( | |
| const txInitializeBridge = await sovereignChainBridgeContract.initialize( |
| expectedStorageModifications.BridgeL2SovereignChain = await getExpectedStorageProxy( | ||
| sovereignChainBridgeContract.target, | ||
| ); | ||
| // Bridge initialitzation |
Contributor
There was a problem hiding this comment.
Suggested change
| // Bridge initialitzation | |
| // Bridge initialization |
| JSON.stringify(actualStorage, null, 2), | ||
| ); | ||
|
|
||
| let equal = await deepEqual(storageModifications, expectedStorageModifications); |
|
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
2 times, most recently
from
94f02f3 to
7e88563
Compare
ignasirv
suggested changes
Aug 26, 2025
| - `useAggOracleCommittee`: `true/false`. Indicates if use aggOracleCommittee | ||
| - if `useAggOracleCommittee == true`: | ||
| - `ownerAddress`: Address that will own the AggOracleCommittee contract (typically a timelock contract) | ||
| - `aggOracleMembers`: Array of addresses that will act as initial oracle members |
Contributor
There was a problem hiding this comment.
Params are "aggOracleCommittee", "aggOracleOwner" according to the code
krlosMata
requested changes
Sep 12, 2025
| tokenWrappedAddress.toLocaleLowerCase().slice(2), | ||
| ); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Rebase with the commit of feature/v12.
Add bridgeLib since it is the latest SC deployed automatically by the bridge.
| @@ -0,0 +1,120 @@ | |||
| # Create sovereign genesis | |||
| Script to generate the genesis file for a rollup with `SovereignContracts`. This genesis is aimed to be used for chains that are run with vanilla clients. | |||
Member
There was a problem hiding this comment.
Add warning code is not audited yep
| const dateStr = new Date().toISOString(); | ||
|
|
||
| async function main() { | ||
| logger.info('Start create-sovereign-genesis tool'); |
Member
There was a problem hiding this comment.
add logger warning --> code is not audited yet
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
from
d586c3a to
9a29126
Compare
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
3 times, most recently
from
a328d9c to
92a1745
Compare
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
from
92a1745 to
08e5d1b
Compare
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
from
c0bfe4d to
01101af
Compare
laisolizq
force-pushed
the
feature/sovereign-genesis-hardhat
branch
from
dc8f9b8 to
28d550d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tool to create genesis with anvil