Skip to content

Move duplicated functions to utils#577

Draft
alrevuelta wants to merge 1 commit intodevelopfrom
move-utils
Draft

Move duplicated functions to utils#577
alrevuelta wants to merge 1 commit intodevelopfrom
move-utils

Conversation

@alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Nov 26, 2025

  • This PR simply moves duplicated code into utils.
  • The following functions were duplicated all over the place calculateGlobalExitRoot, calculateGlobalExitRootLeaf, calculateAccInputHashetrog, computeGlobalIndex.
  • This PR moves them to utils so that they are referenced from a single place.

@alrevuelta alrevuelta changed the base branch from main to feature/v12 November 26, 2025 12:10
@alrevuelta alrevuelta changed the title Move utils Move duplicated functions to utils Nov 26, 2025
@krlosMata
Copy link
Member

krlosMata commented Dec 2, 2025

This cleanup will come with v13, I'd suggest to change the PR to draft

@alrevuelta alrevuelta marked this pull request as draft December 2, 2025 17:30
Base automatically changed from feature/v12 to develop December 19, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@krlosMata krlosMata Awaiting requested review from krlosMata krlosMata is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alrevuelta @krlosMata