libcamera: fix c++ flags and failed buildpaths QA check#1416
Merged
agherzan merged 1 commit intoagherzan:masterfrom Feb 14, 2025
OldManYellsAtCloud:master
Merged
libcamera: fix c++ flags and failed buildpaths QA check#1416agherzan merged 1 commit intoagherzan:masterfrom OldManYellsAtCloud:master
agherzan merged 1 commit intoagherzan:masterfrom
OldManYellsAtCloud:master
Conversation
Building libcamera from the latest version of meta-or fails the buildpaths qa check with a number of generated binaries. Looking into the logs, it seemed that the -f*-prefix-map flags were present to gcc invocations, but the used flags were quite off for g++ invocations. It seems that using the cpp_args meson option overwrites (at least most of) the CXXFLAGS set by Yocto, including the -f*-prefix-map flags. To avoid this, append the extra compile flag to the CXXFLAGS variable instead of using meson's cpp_args option. Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building libcamera from the latest meta-oe fails with QA check error:
Looking into the logs, it seems the
cpp_argsoption (used in the PACKAGECONFIG) were overriding most of the CXXFLAGS from Yocto, including the removal of the-f*-prefix-mapoptions, which left the buildpath in the binaries. To fix this, add the-Wno-unaligned-accessflag toCXXFLAGSinstead of using meson's cpp_args option.Same g++ invocation before (upper) and after (lower) the change: