Relax UBOOT_ENTRYPOINT and UBOOT_LOADADDRESS default definitions (scarthgap)#1574
Relax UBOOT_ENTRYPOINT and UBOOT_LOADADDRESS default definitions (scarthgap)#1574embetrix wants to merge 1 commit intoagherzan:scarthgapfrom
Conversation
embetrix
changed the title
agherzan
left a comment
agherzan
left a comment
There was a problem hiding this comment.
This looks good. Thanks for looking into it and putting up the PR. Could I ask you to chisel a bit the git log message to match the layer's contributions guidelines? You will find git history also useful in examples.
Set UBOOT_ENTRYPOINT/UBOOT_LOADADDRESS using the weak assignment operator (?=) to allow for easier override in downstream layers or machine configurations without forcing a hardcoded value. Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
embetrix
force-pushed
the
feature/relax-settting-uboot-entry-addresses
branch
from
6af32cb to
0f54148
Compare
@agherzan I did rework the MR with your suggestion, hope its' okay now |
agherzan
left a comment
agherzan
left a comment
There was a problem hiding this comment.
Thanks for this. Makes sense to me.
|
@agherzan I’d ike to ask about the status of pending merge requests in general including mine, which have not received feedback for quite some time... Contributors put significant efforts into implementing and testing their changes and even brief feedback or a review update would be greatly appreciated. this can discourage people and may drive contributors away over time. perhaps consider handing over or sharing maintenance responsibilities with others who are willing to help? |
|
any update on this ? |
2 participants
linux-raspberrypi.inc: relax uboot ENTRYPOINT/LOADADDRESS definitions
Set UBOOT_ENTRYPOINT/UBOOT_LOADADDRESS using the weak assignment operator (?=)
to allow for easier override in downstream layers or machine configurations
without forcing a hardcoded value.