Skip to content

weston: Update patch to apply to latest weston#1584

Open
kraj wants to merge 1 commit intoagherzan:masterfrom
YoeDistro:yoe/mut
Open

weston: Update patch to apply to latest weston#1584
kraj wants to merge 1 commit intoagherzan:masterfrom
YoeDistro:yoe/mut

Conversation

@kraj
Copy link
Collaborator

@kraj kraj commented Mar 24, 2026

No description provided.

Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com>
@OldManYellsAtCloud
Copy link
Contributor

I am not sure if that patch is still needed at all. The latest weston had the failing assertion removed (exactly because of the same issue why this patch was created), and it supposed to work without crashing...

(This is the theory, at least. It remains to be tried in practice)

@kraj
Copy link
Collaborator Author

kraj commented Mar 24, 2026

it seems to work with this patch, I am not sure without the patch, but I agree it will be good to drop it if possible. I know it failed randomly so not sure if it can be validated. I know you had a testcase to reproduce the original problem.

@OldManYellsAtCloud
Copy link
Contributor

OldManYellsAtCloud commented Mar 24, 2026

It failed randomly? I haven't heard of it - do you have a link or something? (Edit: or you just mean the original problem, not failure with the patch?)

I can try to test it, but only later this week - it's firefox update season, and that will occupy my machine for a while.

@kraj
Copy link
Collaborator Author

kraj commented Mar 24, 2026

It failed randomly? I haven't heard of it - do you have a link or something? (Edit: or you just mean the original problem, not failure with the patch?)

That was my problem, where weston will launch and stay up for a while, as soon as I did something with it e.g. launch a browser app, it would crash. This was surmounting to same problem that you were running into and this patch helped to fix that.

I can try to test it, but only later this week - it's firefox update season, and that will occupy my machine for a while.

@OldManYellsAtCloud
Copy link
Contributor

Ah, that - sure. That wasn't random, at least on my machine, that confused me. Will report back in a few days when I get around building an rpi image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants