deps: fix install on Node 22.14+ by updating canvas et al#132
Merged
Conversation
- a `prebuild-install` bug is causing CI to fail to install `canvas` on Node 22 - update the patch in the lockfile - while at it, bump `canvas` too to a newer version with less deps
agilgur5
added
kind: bug
scope: upstream
This comment was marked as resolved.
This comment was marked as resolved.
agilgur5
changed the title
canvas and prebuild-installcanvas et al
agilgur5
changed the title
canvas et alcanvas et al
agilgur5
commented
Mar 29, 2025
Owner
Author
agilgur5
left a comment
agilgur5
left a comment
There was a problem hiding this comment.
✅ LGTM and CI is all green now!
1 task
Hamza65523
pushed a commit
to Hamza65523/react-signature-canvas
that referenced
this pull request
Nov 2, 2025
…#132) - a `napi-build-utils` bug caused a bug in `prebuild-install` which causes `canvas` to fail to fetch prebuilds (and CI to partially fail) during installation of `canvas` on Node 22.14+ - update the patch in the lockfile - while at it, bump `canvas` too to a newer version with less deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
canvasand its deps to fix installation issues on Node 22.14+Details
napi-build-utilsbug (getBestNapiBuildVersion() fails on Node 23.6.0 inspiredware/napi-build-utils#6) caused a bug inprebuild-install(prebuild-install fails to determine target on Node 23.6.0 prebuild/prebuild-install#203) which causescanvasto fail to fetch prebuilds on Node 22.14+ per Build Error: Incompatibility ofcanvas@2.11.2with Node.js v22.11.0 Automattic/node-canvas#2448 (comment).canvastoo to a newer version with less depsReferences
I described this in significant detail in Automattic/node-canvas#2448 (comment), linking back to the Node 22.x CI failures on #126, #130, and their merged commits (also #131 and its merged commit now) and fortunately a maintainer responded there pretty quickly with the root cause.