Respect $ZDOTDIR on installation - #97
Open
Sneethe wants to merge 3 commits into
Open
Conversation
This better follows ZSH behavior on where to put ZSH files.
Author
|
And as for why. Well if a user has gone out of their way to configure Also I felt it made sense for .z to be in the same path as .zsh_history |
Author
|
Just read through #20.
I do however agree with bavalpey that the number of people who use both zsh-z and bash's z simultaneously has to very small. This PR would only break rupa/z if a user did the following steps in order:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This conforms to ZSH behavior on where to put ZSH files.
As
$ZDOTDIRis where things like.zshrcand.zsh_historyis stored.For majority of users
$ZDOTDIRwill =$HOMEthus the default location is preserved.If user has changed
$ZDOTDIRto say$HOME/.config/zshthen upon this plugin's installation,.zwill be in$HOME/.config/zshTo avoid breakage for users who have set a custom
$ZDOTDIRto something other than$HOME. but haven't changed the default database location of$HOME/.zWe do this:
So even if
$ZDOTDIRhas been customized, we still default to the default database file location if it exists.And thank you for making this plugin. Its very much appreciated.