Testrun timo #9
Open
Testrun timo #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateam#6909) The doc updates include the changes of commits b6d0fe5, e768b70, TODO PR wait, TODO PR renaming to force
Fix config path in legacy aiida_instance pytest fixture Update .github/workflows/ci-code.yml Co-authored-by: Alexander Goscinski <[email protected]>
The original design of `wait` and `timeout` was to distinguish between actions that immediately return and actions that scheduled. This mechanism was however never used and resulted in an misinterpretation in the force-kill PR aiidateam#6793 introducing a bug fixed in PR aiidateam#6870. The mechanism of `wait` and `timeout` was also never correctly implemented. In this PR we rectify the logic and simplify it by handling immediate and scheduled actions the same way. Related commits in aiida-core 8388018, cd0d15c and plumpy 1b6ecb8 One can specifiy a `timeout <= 0` to express that the action should not wait for a response while one can specify `timeout==float('inf')` (default value) to wait until a response has been received without a timeout.
fix conflicts fix tests fix copy function
review applied r 2 fixed a typo in function signature fields updated review applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verdi computer createit is a bit confusing since you have to actually specify theHost(as used in the ssh config), also that you have the option two times why? -> Because we still need the option for thecore.sshplugin. Put a help text into it to explain it a bit.StashModeaiidateam/aiida-core#6916StashCalculationdoes not wait until specified CalcJob finished aiidateam/aiida-core#6915ssh_async--> I must have overlooked it, it is thereverdi profile dump --groups <ID>does not work while dumpingverdi group dump <ID>verdi process kill -t -1is not checked to False, raise error that timeout is negative warningverdi process kill -t 0should report some information that it does not wait