Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds environment configuration to the GitHub Actions deployment workflow to specify that the deploy job runs in a production environment.
- Adds environment specification to the deploy job in the release workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Visit the preview URL for this PR (updated for commit c129975): |
steveoh
approved these changes
Oct 16, 2025
Contributor
steveoh
left a comment
steveoh
left a comment
There was a problem hiding this comment.
yes it should! The federation included an environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm wondering if this will fix the npm publish.