Skip to content

fix(fileinput): fix description contrast in dark mode#565

Merged
stdavis merged 1 commit intomainfrom
fix/dark-file-input
Dec 2, 2025
Merged

fix(fileinput): fix description contrast in dark mode#565
stdavis merged 1 commit intomainfrom
fix/dark-file-input

Conversation

@stdavis
Copy link
Copy Markdown
Member

@stdavis stdavis commented Dec 2, 2025

The WAVE tool shows a warning and error because the label does not have a corresponding form control and the hidden input does not have a corresponding label. I couldn't figure out a way to connect the two. The hidden input does not have any id attribute.

Copilot AI review requested due to automatic review settings December 2, 2025 19:52
@stdavis stdavis enabled auto-merge (rebase) December 2, 2025 19:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves accessibility by adding dark mode text color styling to the Description component, addressing contrast issues in dark mode that were flagged by the WAVE accessibility tool.

  • Adds dark:text-zinc-400 class to the Description component for better contrast in dark mode
  • Maintains the existing light mode styling with text-gray-600

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025

Visit the preview URL for this PR (updated for commit d579233):
Firebase Preview: https://ut-dts-agrc-kitchen-sink-dev--fix-dark-file-input-78v9kno2.web.app
(expires "2025-12-16T19:56:01.056095587Z" )

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stdavis stdavis merged commit 2280834 into main Dec 2, 2025
19 checks passed
@stdavis stdavis deleted the fix/dark-file-input branch December 2, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants