feat(fileinput): implement controlled file input with onChange callback#568
Merged
feat(fileinput): implement controlled file input with onChange callback#568
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements controlled component support for the FileInput component, enabling external state management and programmatic clearing of files. This is needed to support clearing the FileInput state in WRI advanced search.
Key changes:
- Replaced
onSelectcallback (receivingFileList | null) withonChangecallback (receivingFile[] | null) - Added
valueandonChangeprops to support controlled mode while maintaining backward compatibility with uncontrolled mode - Simplified file management by removing DataTransfer API complexity
- Updated ReactHookForm integration to use the new controlled API
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/utah-design-system/src/components/FileInput.tsx | Implements controlled/uncontrolled component pattern with value/onChange props, replaces onSelect with onChange callback, simplifies file state management |
| packages/utah-design-system/src/components/FileInput.stories.tsx | Updates ReactHookForm story to use new onChange API, adds Controlled story demonstrating external state management with reset functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Visit the preview URL for this PR (updated for commit 1451cc4): |
Contributor
#569) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stdavis <1326248+stdavis@users.noreply.github.com>
steveoh
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support clearing the FileInput state in WRI advanced search.