Skip to content

feat: display interior points as white#410

Merged
steveoh merged 6 commits intodevfrom
feat/interior-points
Feb 4, 2025
Merged

feat: display interior points as white#410
steveoh merged 6 commits intodevfrom
feat/interior-points

Conversation

@steveoh
Copy link
Copy Markdown
Contributor

@steveoh steveoh commented Feb 3, 2025

this displays the interior points as white.

Adding sean and erik as reviewers. Please test the preview to see if you are happy with the symbology. We can test the other parts of the app in dev once the symbology looks good.

You don't have to review the code. Scott can take care of that.

this moves the rendering out of the feature layer and into app code
@steveoh steveoh changed the base branch from main to dev February 3, 2025 23:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2025

Visit the preview URL for this PR (updated for commit 19e4193):
Firebase Preview: https://ut-dts-agrc-plss-dev--feat-interior-points-iaf4m8e0.web.app
(expires "2025-02-18T18:38:08.885724932Z" )

@steveoh steveoh marked this pull request as draft February 3, 2025 23:55
@steveoh steveoh force-pushed the feat/interior-points branch from 6471ae1 to 3df25b5 Compare February 4, 2025 00:48
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy bot commented Feb 4, 2025

Code Climate has analyzed commit f8891b1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5899 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6191 lines exceeds the maximum allowed for the inline comments feature.

@seanfernandez
Copy link
Copy Markdown

I have reviewed the dev version of the PLSS app with the new interior points and I say we move forward with these small white points and this scale dependency. Looks great! Once it is available in dev we should test to see if we can submit a monument record sheet before going live.

Also, the description for these points should be this:
The PLSS points within the BLM's Geographic Coordinate Database (GCDB) for quarter-quarter sections, center sections, and some meander and lot points are calculated rather than directly surveyed. These points represent interior breakdowns of sections.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6192 lines exceeds the maximum allowed for the inline comments feature.

@steveoh steveoh marked this pull request as ready for review February 4, 2025 19:41
@steveoh steveoh merged commit 6e9023d into dev Feb 4, 2025
@steveoh steveoh deleted the feat/interior-points branch February 4, 2025 21:12
@steveoh steveoh mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants