Skip to content

Update a few more dependencies#415

Merged
steveoh merged 3 commits intomainfrom
refactor/tailwind-v4
Feb 5, 2025
Merged

Update a few more dependencies#415
steveoh merged 3 commits intomainfrom
refactor/tailwind-v4

Conversation

@steveoh
Copy link
Copy Markdown
Contributor

@steveoh steveoh commented Feb 5, 2025

this was a good candidate to check out tailwind 4

@steveoh steveoh requested a review from stdavis February 5, 2025 02:12
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit fd3c38c and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

Visit the preview URL for this PR (updated for commit 1077d7a):
Firebase Preview: https://ut-dts-agrc-plss-dev--refactor-tailwind-v4-o8pu5sak.web.app
(expires "2025-02-19T16:52:18.330088104Z" )

@steveoh steveoh mentioned this pull request Feb 5, 2025
Copy link
Copy Markdown
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a selection border issue when you click on a point. I'm not sure if this is a regression specific to this set of changes or not. It's not present in production.
image

Base automatically changed from dev to main February 5, 2025 15:31
@steveoh
Copy link
Copy Markdown
Contributor Author

steveoh commented Feb 5, 2025

I'll get that. I thought it was already working. How did you focus it? And what's up with the strange dark mode parts. This app doesn't support it.

@stdavis
Copy link
Copy Markdown
Member

stdavis commented Feb 5, 2025

How did you focus it?

Clicking on a point brought the focus ring out for me.

And what's up with the strange dark mode parts.

That's a chrome extension that I have. You can ignore them.

@steveoh steveoh requested a review from stdavis February 5, 2025 16:47
@steveoh
Copy link
Copy Markdown
Contributor Author

steveoh commented Feb 5, 2025

I'll get these conflicts sorted out and we decided the css issues are from a chrome extension and not a part of the app.

@steveoh steveoh merged commit 7e0ba09 into main Feb 5, 2025
@steveoh steveoh deleted the refactor/tailwind-v4 branch February 5, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants