Conversation
witness corner, meander corner, and reference corner closes #438
|
Code Climate has analyzed commit 5b196c4 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit 8c3f124): |
steveoh
force-pushed
the
refactor/remove-reactfire
branch
from
8f92af2 to
8c70570
Compare
steveoh
force-pushed
the
refactor/remove-reactfire
branch
from
8c70570 to
7f714b8
Compare
stdavis
approved these changes
Mar 25, 2025
Member
stdavis
left a comment
stdavis
left a comment
There was a problem hiding this comment.
Just some cleanup suggestions.
stdavis
reviewed
Mar 25, 2025
stdavis
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
reactfire → 🔥
npm → pnpm
eslint.config
dependency updates
unresolved issues
I wasn't aware, with the firebase contexts we have now, how to mock a logged in user for example. Therefore some stories are broken.
refs
closes